feat: add cancel button to logout #59
Conversation
There was a problem hiding this comment.
{% url 'account_login' as login_url %}
{% element form method="get" action=login_url %}
{% slot actions %}
{% element button type="submit" %}
{% trans 'Cancel' %}
{% endelement %}
{% endslot %}
{% endelement %}
This is one of the pythonic way I found to do this. :-)
templates/account/logout.html
Outdated
| {% endslot %} | ||
| {% endelement %} | ||
| <script> | ||
| document.getElementById('cancel-button').addEventListener('click', function() { | ||
| history.back(); |
There was a problem hiding this comment.
using history.back() may be unpredictable sometimes, I think it is better to do it in a pythonic way.
There was a problem hiding this comment.
Yeah I agree with not using Javascript for this.
|
Another option is to simply log people out without the confirmation step. |
|
Thanks for the insights! @Mariatta I agree removing the confirmation step simplifies the flow. Proposal: Let’s proceed with removing the confirmation (per @Mariatta’s suggestion) since it reduces complexity. We can revisit the cancel button pattern if needed later. Unless there are objections, I’ll update the PR shortly. |
|
I've added the ACCOUNT_LOGOUT_ON_GET = True setting to the AllAuth configuration to enable direct user logout without requiring a confirmation page. Since JavaScript isn't currently being used for this functionality, I thought this settings-based approach might be the simplest solution while maintaining compatibility with the rest of the system. If JavaScript becomes an option in the future, we could consider implementing an approach that converts a logout link click into a POST request while still avoiding the confirmation page. Please let me know if there's a different approach you'd prefer for handling this requirement. |
There was a problem hiding this comment.
- Please remove
__pycache__folder.
To remove pycache file now after commit please reference to this stackoverflow link: https://stackoverflow.com/a/71930352/16563091
- Just one change, and we are good to go.
Removed pycache and added it to .gitignore. Thanks for the suggestion @Mr-Sunglasses |
fix: #57